fix: updated GCP validation to always consider 403 response as valid result#383
Merged
cx-diogo-rocha merged 4 commits intomasterfrom Apr 17, 2026
Merged
Conversation
|
KICS version: v1.7.13
|
|
Great job! No new security vulnerabilities introduced in this pull request |
…7054-fix-inconsistent-validity-gcp-api-key
cx-julio-silva
approved these changes
Apr 17, 2026
cx-julio-silva
approved these changes
Apr 17, 2026
cx-diogo-rocha
deleted the
AST-147054-fix-inconsistent-validity-gcp-api-key
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
We had an issue where GCP API Keys were having inconsistent validation, varying from Valid to Unknown depending on the response body.
After testing the API, we concluded that 403-Forbidden code is only received if the token is valid. It might, however, not be valid to the API we are testing (Youtube API). But it is still valid as a GCP API Key.
Therefore we are treating all 403 codes as Valid, unless an error occurred on parsing the response body (this error behavior was already present)
Checklist
I submit this contribution under the Apache-2.0 license.